summaryrefslogtreecommitdiff
path: root/drivers/net/ethernet/natsemi/sonic.c
diff options
context:
space:
mode:
authorVincent Chen <vincentc@andestech.com>2018-11-21 09:38:11 +0800
committerDavid S. Miller <davem@davemloft.net>2018-11-21 16:57:39 -0800
commit426a593e641ebf0d9288f0a2fcab644a86820220 (patch)
tree9da1b8b14386d93e424e6e361567697d2f4bf392 /drivers/net/ethernet/natsemi/sonic.c
parent395048ebd4547d3cced71807b8aabfbde000fe55 (diff)
net: faraday: ftmac100: remove netif_running(netdev) check before disabling interrupts
In the original ftmac100_interrupt(), the interrupts are only disabled when the condition "netif_running(netdev)" is true. However, this condition causes kerenl hang in the following case. When the user requests to disable the network device, kernel will clear the bit __LINK_STATE_START from the dev->state and then call the driver's ndo_stop function. Network device interrupts are not blocked during this process. If an interrupt occurs between clearing __LINK_STATE_START and stopping network device, kernel cannot disable the interrupts due to the condition "netif_running(netdev)" in the ISR. Hence, kernel will hang due to the continuous interruption of the network device. In order to solve the above problem, the interrupts of the network device should always be disabled in the ISR without being restricted by the condition "netif_running(netdev)". [V2] Remove unnecessary curly braces. Signed-off-by: Vincent Chen <vincentc@andestech.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/natsemi/sonic.c')
0 files changed, 0 insertions, 0 deletions