summaryrefslogtreecommitdiff
path: root/drivers/mfd/pcf50633-irq.c
diff options
context:
space:
mode:
authorMitch Williams <mitch.a.williams@intel.com>2014-11-11 20:02:19 +0000
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2014-11-20 14:56:42 -0800
commit1001dc3739a9b29946ff595eb4b02a1082ad4e7b (patch)
tree149105b4d4a143b036250e2c719941fdac3495c7 /drivers/mfd/pcf50633-irq.c
parent688ff32db2f7e7074df4eb6871afa65dee41c98f (diff)
i40e: don't overload fields
Overloading the msg_size field in the arq_event_info struct is just a bad idea. It leads to repeated bugs when the structure is used in a loop, since the input value (buffer size) is overwritten by the output value (actual message length). Fix this by splitting the field into two and renaming to indicate the actual function of each field. Since the arq_event struct has now changed, we need to change the drivers to support this. Note that we no longer need to initialize the buffer size each time we go through a loop as this value is no longer destroyed by arq processing. In the process, we also fix a bug in i40evf_verify_api_ver where the buffer size was not correctly reinitialized each time through the loop. Change-ID: Ic7f9633cdd6f871f93e698dfb095e29c696f5581 Signed-off-by: Mitch Williams <mitch.a.williams@intel.com> Acked-by: Shannon Nelson <shannon.nelson@intel.com> Acked-by: Ashish Shah <ashish.n.shah@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/mfd/pcf50633-irq.c')
0 files changed, 0 insertions, 0 deletions