diff options
author | dingtianhong <dingtianhong@huawei.com> | 2013-10-24 11:09:17 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-10-27 16:36:29 -0400 |
commit | 7f1bb571b753ac75b6548f0b7c932dfc0bb1f970 (patch) | |
tree | 3160db2f888f938d0dcc9547e0c6e206c5f091d9 /drivers/leds | |
parent | 2d0dafb0152a6ac61cd31d38c3ef3d49463b6a57 (diff) |
bonding: remove bond read lock for bond_loadbalance_arp_mon()
The bond slave list may change when the monitor is running, the slave list is no longer
protected by bond->lock, only protected by rtnl lock(), so we have 3 ways to modify it:
1.add bond_master_upper_dev_link() and bond_upper_dev_unlink() in bond->lock, but it is unsafe
to call call_netdevice_notifiers() in write lock.
2.remove unused bond->lock for monitor function, only use the existing rtnl lock().
3.use rcu_read_lock() to protect it, of course, it will transform bond_for_each_slave to
bond_for_each_slave_rcu() and performance is better, but in slow path, it is ignored.
so I remove the bond->lock and add the rtnl lock to protect the whole monitor function.
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/leds')
0 files changed, 0 insertions, 0 deletions