diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2020-10-07 10:51:48 +0300 |
---|---|---|
committer | Guenter Roeck <linux@roeck-us.net> | 2020-12-02 17:42:22 -0800 |
commit | 96eca8c97fccd3c02f61a87b0341a079b4096730 (patch) | |
tree | c4138ffcfa285661924f9613b3ea81c51ec5cc06 /drivers/hwmon/f71805f.c | |
parent | bce776f10069c806290eaac712ba73432ae8ecd7 (diff) |
hwmon: (acpi_power_meter) clean up freeing code
This code works okay but Smatch flagged it as a double free. I've
changed three things to make it more clear. 1) Remove the call to
free_capabilities() in acpi_power_meter_add(). This call is a no-op
because the capabilities have not been allocated yet. 2) Set "*str" to
NULL in free_capabilities() so that way the function can be called twice
in a row without leading to a double free. 3) Call free_capabilities()
in read_capabilities() instead of open coding the free.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20201007075148.GB2529578@mwanda
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/f71805f.c')
0 files changed, 0 insertions, 0 deletions