diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2020-05-20 18:25:56 +0300 |
|---|---|---|
| committer | Alex Deucher <alexander.deucher@amd.com> | 2020-05-21 12:48:43 -0400 |
| commit | 62cc895c02fb9d1170f02dc1dfa3c2135ebe100b (patch) | |
| tree | 3d2cde0070633b331233887e16bcdb2383fccc60 /drivers/gpu/drm/i915/i915_debugfs.c | |
| parent | 94f2026bd82ed00b86b0423ec40d9e8b95052121 (diff) | |
drm/amdgpu: off by one in amdgpu_device_attr_create_groups() error handling
This loop in the error handling code should start a "i - 1" and end at
"i == 0". Currently it starts a "i" and ends at "i == 1". The result
is that it removes one attribute that wasn't created yet, and leaks the
zeroeth attribute.
Fixes: 4e01847c38f7 ("drm/amdgpu: optimize amdgpu device attribute code")
Acked-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Kevin Wang <kevin1.wang@amd.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/i915/i915_debugfs.c')
0 files changed, 0 insertions, 0 deletions