summaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authoryongduan <yongduan@tencent.com>2019-09-11 17:44:24 +0800
committerMichael S. Tsirkin <mst@redhat.com>2019-09-11 15:15:26 -0400
commit060423bfdee3f8bc6e2c1bac97de24d5415e2bc4 (patch)
tree1d29fdf287bcd13ee916712b2d31ac2cd6ad449d /block
parenta89db445fbd7f1f8457b03759aa7343fa530ef6b (diff)
vhost: make sure log_num < in_num
The code assumes log_num < in_num everywhere, and that is true as long as in_num is incremented by descriptor iov count, and log_num by 1. However this breaks if there's a zero sized descriptor. As a result, if a malicious guest creates a vring desc with desc.len = 0, it may cause the host kernel to crash by overflowing the log array. This bug can be triggered during the VM migration. There's no need to log when desc.len = 0, so just don't increment log_num in this case. Fixes: 3a4d5c94e959 ("vhost_net: a kernel-level virtio server") Cc: stable@vger.kernel.org Reviewed-by: Lidong Chen <lidongchen@tencent.com> Signed-off-by: ruippan <ruippan@tencent.com> Signed-off-by: yongduan <yongduan@tencent.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Tyler Hicks <tyhicks@canonical.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions