summaryrefslogtreecommitdiff
path: root/Kbuild
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2015-11-16 17:25:48 +0100
committerCatalin Marinas <catalin.marinas@arm.com>2015-11-17 12:05:18 +0000
commit1dccb598df549d892b6450c261da54cdd7af44b4 (patch)
treefea8192dbd332bf36c235552250b3d70340250c8 /Kbuild
parent4fee9f364b9b99f76732f2a6fd6df679a237fa74 (diff)
arm64: simplify dma_get_ops
Including linux/acpi.h from asm/dma-mapping.h causes tons of compile-time warnings, e.g. drivers/isdn/mISDN/dsp_ecdis.h:43:0: warning: "FALSE" redefined drivers/isdn/mISDN/dsp_ecdis.h:44:0: warning: "TRUE" redefined drivers/net/fddi/skfp/h/targetos.h:62:0: warning: "TRUE" redefined drivers/net/fddi/skfp/h/targetos.h:63:0: warning: "FALSE" redefined However, it looks like the dependency should not even there as I do not see why __generic_dma_ops() cares about whether we have an ACPI based system or not. The current behavior is to fall back to the global dma_ops when a device has not set its own dma_ops, but only for DT based systems. This seems dangerous, as a random device might have different requirements regarding IOMMU or coherency, so we should really never have that fallback and just forbid DMA when we have not initialized DMA for a device. This removes the global dma_ops variable and the special-casing for ACPI, and just returns the dma ops that got set for the device, or the dummy_dma_ops if none were present. The original code has apparently been copied from arm32 where we rely on it for ISA devices things like the floppy controller, but we should have no such devices on ARM64. Signed-off-by: Arnd Bergmann <arnd@arndb.de> [catalin.marinas@arm.com: removed acpi_disabled check in arch_setup_dma_ops()] Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Diffstat (limited to 'Kbuild')
0 files changed, 0 insertions, 0 deletions