summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSuzuki K Poulose <Suzuki.Poulose@arm.com>2018-12-10 18:07:33 +0000
committerWill Deacon <will.deacon@arm.com>2018-12-10 18:42:18 +0000
commitf357b3a7e17af7736d67d8267edc1ed3d1dd9391 (patch)
tree6a9aecc9726b7bb1b56d71201874f59ebfa70da9
parent66f16a24512fa44680504effe908df8326885594 (diff)
arm64: smp: Handle errors reported by the firmware
The __cpu_up() routine ignores the errors reported by the firmware for a CPU bringup operation and looks for the error status set by the booting CPU. If the CPU never entered the kernel, we could end up in assuming stale error status, which otherwise would have been set/cleared appropriately by the booting CPU. Reported-by: Steve Capper <steve.capper@arm.com> Cc: Will Deacon <will.deacon@arm.com> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> Signed-off-by: Will Deacon <will.deacon@arm.com>
-rw-r--r--arch/arm64/kernel/smp.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 4e3bfbde829a..1598d6f7200a 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -141,6 +141,7 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle)
}
} else {
pr_err("CPU%u: failed to boot: %d\n", cpu, ret);
+ return ret;
}
secondary_data.task = NULL;