diff options
| author | Julia Lawall <julia@diku.dk> | 2009-07-28 17:52:56 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-09-15 12:02:06 -0700 |
| commit | d0e0507ad6ccbeaad1f6bfe5923bdc5110df8636 (patch) | |
| tree | 86faef7d4382cfd639c7fa886bab435f0eea22f1 | |
| parent | b6ac161364eccce1bea4a23a9de395883e90d7ab (diff) | |
Staging: dst: correct error-handling code
dst_state_alloc returns an ERR_PTR value in an error case instead of NULL.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@match exists@
expression x, E;
statement S1, S2;
@@
x = dst_state_alloc(...)
... when != x = E
(
* if (x == NULL || ...) S1 else S2
|
* if (x == NULL && ...) S1 else S2
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/staging/dst/export.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/dst/export.c b/drivers/staging/dst/export.c index 80ae4ebe610a..4fbd848bd14f 100644 --- a/drivers/staging/dst/export.c +++ b/drivers/staging/dst/export.c @@ -159,7 +159,7 @@ static struct dst_state *dst_accept_client(struct dst_state *st) goto err_out_exit; new = dst_state_alloc(st->node); - if (!new) { + if (IS_ERR(new)) { err = -ENOMEM; goto err_out_release; } |