diff options
| author | Tim Collier <osdevtc@gmail.com> | 2018-05-25 18:40:40 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-05-31 19:00:53 +0200 |
| commit | bb1192cbf43ec5b0db9ed593fa150cba917642ae (patch) | |
| tree | e7399d279ccfcd356ba3b8483371a67990c7c45a | |
| parent | 889cea43c54b91b92011649ce53db4fdc51ed86c (diff) | |
staging: wlan-ng: remove unused declarations from p80211types.h
A number of extern struct declarations in p80211types.h were causing
checkpatch warnings: "extern prototypes should be avoided in .h files"
and "function definition argument 'xxxxxx' should also have an
identifier name".
This appears to be a result of using a macro to form the declarations
and checkpatch consequently misinterpreting the declarations as
function prototypes.
On checking, the declarations have no corresponding definition in the
driver and are not used, so they are removed along with the macro used
to construct them, which is not needed elsewhere. After this change,
checkpatch reports that p80211types.h has no obvious issues.
Signed-off-by: Tim Collier <osdevtc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/wlan-ng/p80211types.h | 31 |
1 files changed, 0 insertions, 31 deletions
diff --git a/drivers/staging/wlan-ng/p80211types.h b/drivers/staging/wlan-ng/p80211types.h index 388357bbcbf5..7c37d56dd9b7 100644 --- a/drivers/staging/wlan-ng/p80211types.h +++ b/drivers/staging/wlan-ng/p80211types.h @@ -119,11 +119,6 @@ /* is a DID-LEN-DATA triple */ /* with a max size of 4+4+384 */ -/*----------------------------------------------------------------*/ -/* The following macro creates a name for an enum */ - -#define MKENUMNAME(name) p80211enum_ ## name - /*---------------------------------------------------------------- * The following constants and macros are used to construct and * deconstruct the Data ID codes. The coding is as follows: @@ -348,30 +343,4 @@ typedef void (*p80211_fromtext_t) (struct catlistitem *, u32 did, u8 *itembuf, char *textbuf); typedef u32(*p80211_valid_t) (struct catlistitem *, u32 did, u8 *itembuf); -/*----------------------------------------------------------------*/ -/* Enumeration Lists */ -/* The following are the external declarations */ -/* for all enumerations */ - -extern struct p80211enum MKENUMNAME(truth); -extern struct p80211enum MKENUMNAME(ifstate); -extern struct p80211enum MKENUMNAME(powermgmt); -extern struct p80211enum MKENUMNAME(bsstype); -extern struct p80211enum MKENUMNAME(authalg); -extern struct p80211enum MKENUMNAME(phytype); -extern struct p80211enum MKENUMNAME(temptype); -extern struct p80211enum MKENUMNAME(regdomain); -extern struct p80211enum MKENUMNAME(ccamode); -extern struct p80211enum MKENUMNAME(diversity); -extern struct p80211enum MKENUMNAME(scantype); -extern struct p80211enum MKENUMNAME(resultcode); -extern struct p80211enum MKENUMNAME(reason); -extern struct p80211enum MKENUMNAME(status); -extern struct p80211enum MKENUMNAME(msgcode); -extern struct p80211enum MKENUMNAME(msgitem_status); - -extern struct p80211enum MKENUMNAME(lnxroam_reason); - -extern struct p80211enum MKENUMNAME(p2preamble); - #endif /* _P80211TYPES_H */ |