summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTang Bin <tangbin@cmss.chinamobile.com>2021-07-28 09:49:25 +0800
committerDavid S. Miller <davem@davemloft.net>2021-07-28 09:23:59 +0100
commit46573e3ab08fb041d5ba7bf7bf3215a1e724c78c (patch)
tree6ec6620bd0829336818dc79c1c6c2c6b6cb9bdf6
parent9d0279d043e87f119cfeb3200ad2c0e403765975 (diff)
nfc: s3fwrn5: fix undefined parameter values in dev_err()
In the function s3fwrn5_fw_download(), the 'ret' is not assigned, so the correct value should be given in dev_err function. Fixes: a0302ff5906a ("nfc: s3fwrn5: remove unnecessary label") Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> Reviewed-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/nfc/s3fwrn5/firmware.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nfc/s3fwrn5/firmware.c b/drivers/nfc/s3fwrn5/firmware.c
index 1340fab9565e..e3e72b8a29e3 100644
--- a/drivers/nfc/s3fwrn5/firmware.c
+++ b/drivers/nfc/s3fwrn5/firmware.c
@@ -423,7 +423,7 @@ int s3fwrn5_fw_download(struct s3fwrn5_fw_info *fw_info)
if (IS_ERR(tfm)) {
ret = PTR_ERR(tfm);
dev_err(&fw_info->ndev->nfc_dev->dev,
- "Cannot allocate shash (code=%ld)\n", PTR_ERR(tfm));
+ "Cannot allocate shash (code=%pe)\n", tfm);
goto out;
}