diff options
| author | Alex Sidorenko <alexandre.sidorenko@hpe.com> | 2016-10-07 09:02:33 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-10-07 23:50:39 -0400 |
| commit | 21d9629a7abd87512d062fbe57b04a1baedf93d2 (patch) | |
| tree | 7918c00daabbe03ac8a156358ac023a3a959064b | |
| parent | 7d3cfc36ec3aae1d37a13fbe257f31141eb772b4 (diff) | |
Fixing a bug in team driver due to incorrect 'unsigned int' to 'int' conversion
Roundrobin runner of team driver uses 'unsigned int' variable to count
the number of sent_packets. Later it is passed to a subroutine
team_num_to_port_index(struct team *team, int num) as 'num' and when
we reach MAXINT (2**31-1), 'num' becomes negative.
This leads to using incorrect hash-bucket for port lookup
and as a result, packets are dropped. The fix consists of changing
'int num' to 'unsigned int num'. Testing of a fixed kernel shows that
there is no packet drop anymore.
Signed-off-by: Alex Sidorenko <alexandre.sidorenko@hpe.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | include/linux/if_team.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/if_team.h b/include/linux/if_team.h index 174f43f43aff..c05216a8fbac 100644 --- a/include/linux/if_team.h +++ b/include/linux/if_team.h @@ -245,7 +245,7 @@ static inline struct team_port *team_get_port_by_index(struct team *team, return NULL; } -static inline int team_num_to_port_index(struct team *team, int num) +static inline int team_num_to_port_index(struct team *team, unsigned int num) { int en_port_count = ACCESS_ONCE(team->en_port_count); |