<feed xmlns='http://www.w3.org/2005/Atom'>
<title>zmk.git/app/tests/combo/press-release-long-combo-wrong-last-key/events.patterns, branch master</title>
<subtitle>ZMK Bluetooth keyboard firmware.
</subtitle>
<link rel='alternate' type='text/html' href='http://git.nvandoorn.com/zmk.git/'/>
<entry>
<title>fix(combos): Check each combo key, not just last</title>
<updated>2021-06-09T00:35:58+00:00</updated>
<author>
<name>Jonathan Rascher</name>
<email>jon@bcat.name</email>
</author>
<published>2021-06-08T15:56:02+00:00</published>
<link rel='alternate' type='text/html' href='http://git.nvandoorn.com/zmk.git/commit/?id=4e69a32103a2905b9a32c80c8d3d798fbb0d9a0f'/>
<id>4e69a32103a2905b9a32c80c8d3d798fbb0d9a0f</id>
<content type='text'>
The current combo completion check only makes sure the last key in the
combo is set. This works when the combo is typed correctly initially, or
when reraising events in a combo of length two. However, it fails for
longer combos since the last event in pressed_keys might be set, but the
first (or subsequent) event in pressed_keys can be NULL thanks to
release_pressed_keys.

Also added a regression test.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The current combo completion check only makes sure the last key in the
combo is set. This works when the combo is typed correctly initially, or
when reraising events in a combo of length two. However, it fails for
longer combos since the last event in pressed_keys might be set, but the
first (or subsequent) event in pressed_keys can be NULL thanks to
release_pressed_keys.

Also added a regression test.
</pre>
</div>
</content>
</entry>
</feed>
